Skip to content

GEODE-4147: Add variability to client rebalance logic.#1284

Merged
upthewaterspout merged 1 commit intoapache:developfrom
PivotalSarge:feature/GEODE-4147
Jan 18, 2018
Merged

GEODE-4147: Add variability to client rebalance logic.#1284
upthewaterspout merged 1 commit intoapache:developfrom
PivotalSarge:feature/GEODE-4147

Conversation

@PivotalSarge
Copy link
Copy Markdown
Contributor

I moved the application of the variance from the pool implementation to the connection manager implementation to avoid impacting too much of the code, which lead to some failing tests.

For some reason the combination of IntelliJ and Spotless expanded some wildcard import statements but I left those as-is.

@upthewaterspout @bschuchardt @WireBaron @galen-pivotal

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Copy link
Copy Markdown
Contributor

@bschuchardt bschuchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Copy Markdown

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still seems odd to me that this doesn't have an equal chance of returning the original value. That being said, this all looks correct.

@upthewaterspout upthewaterspout merged commit 501cfda into apache:develop Jan 18, 2018
@PivotalSarge PivotalSarge deleted the feature/GEODE-4147 branch January 26, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants