GEODE-4310: allow ResourcePermission to take Strings as arguments for… #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmeiliao
requested review from
PurelyApplied,
jdeppe-pivotal,
pdxrunner and
sboorlagadda
jdeppe-pivotal
approved these changes
Jan 18, 2018
Contributor
jdeppe-pivotal
left a comment
jdeppe-pivotal
left a comment
There was a problem hiding this comment.
Approval pending minor OCD changes
| this.target = StringUtils.stripStart(target, Region.SEPARATOR); | ||
| } | ||
| if (key != null) { | ||
| if (key != null) |
Contributor
There was a problem hiding this comment.
Please add a block around the condition even when it's just one line.
| } | ||
|
|
||
| private String parsePart(String part, UnaryOperator<String> operator) { | ||
| if (part == null) |
| */ | ||
| public Resource getResource() { | ||
| return resource; | ||
| if (ALL.equals(resource)) |
| * Returns the operation, could be either ALL, NULL, MANAGE, WRITE or READ | ||
| */ | ||
| public Operation getOperation() { | ||
| if (ALL.equals(operation)) |
… Resource and Operation. * still checks validity of the resource/operation except wildcards. * update tests
jinmeiliao
force-pushed
the
permissions
branch
from
a81f4ee to
2dae31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Resource and Operation.