GEODE-4312: Wait for rebalancing to complete as part of teardown#1302
Merged
jdeppe-pivotal merged 3 commits intoapache:developfrom Jan 19, 2018
Merged
GEODE-4312: Wait for rebalancing to complete as part of teardown#1302jdeppe-pivotal merged 3 commits intoapache:developfrom
jdeppe-pivotal merged 3 commits intoapache:developfrom
Conversation
jdeppe-pivotal
requested review from
PurelyApplied,
jinmeiliao,
kirklund,
pdxrunner and
sboorlagadda
jinmeiliao
approved these changes
Jan 18, 2018
Member
|
thanks for fixing this. I had this failure on my precheckin |
agingade
reviewed
Jan 18, 2018
| private static synchronized void remoteTearDown() { | ||
| try { | ||
| DistributionMessageObserver.setInstance(null); | ||
| waitForNoRebalancing(); |
There was a problem hiding this comment.
Looks like this is test specific...how about having this in "CacheXmlTestCase" instead here...
jdeppe-pivotal
force-pushed
the
feature/GEODE-4312
branch
from
3e03f5f to
2bdff96
Compare
jdeppe-pivotal
force-pushed
the
feature/GEODE-4312
branch
from
2bdff96 to
1d4b342
Compare
jdeppe-pivotal
force-pushed
the
feature/GEODE-4312
branch
from
8c68bb6 to
fa680ec
Compare
pdxrunner
reviewed
Jan 19, 2018
| * Field is static so it doesn't get serialized with SerializableRunnable inner classes. | ||
| */ | ||
| private static InternalCache cache; | ||
| protected static InternalCache cache; |
There was a problem hiding this comment.
Why has the access been changed? There aren't any direct references to cache in this change set.
Contributor
Author
There was a problem hiding this comment.
The change I made is in a subclass (CacheXmlTestCase) and references cache there.
There was a problem hiding this comment.
OK, I missed that reference to the cache during my review.
pdxrunner
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.