GEODE-1942: Limiting random strings to [A-Z] chars#2196
Merged
upthewaterspout merged 2 commits intoapache:developfrom Jul 26, 2018
Merged
GEODE-1942: Limiting random strings to [A-Z] chars#2196upthewaterspout merged 2 commits intoapache:developfrom
upthewaterspout merged 2 commits intoapache:developfrom
Conversation
This test was generating random strings, but some strings were invalid regions names, for example strings starting with __. Limiting the strings the alphabet.
Contributor
Author
|
@balesh2 @mhansonp |
WireBaron
requested changes
Jul 25, 2018
| StringBuilder rString = new StringBuilder(); | ||
| for (int i = 0; i < length; i++) | ||
| rString.append((char) (rand.nextInt(57) + 65)); | ||
| rString.append((char) (rand.nextInt(25) + 65)); |
There was a problem hiding this comment.
nextInt('bound') will give a random value from 0 to 'bound' - 1...so this will actually the limit the random strings to [A-Y]
Get rid of the crazy math entirely and use apache commons random string generation.
WireBaron
approved these changes
Jul 25, 2018
jake-at-work
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was generating random strings, but some strings were invalid
regions names, for example strings starting with __. Limiting the
strings the alphabet.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.