GEODE-5492 Fix gradle dependencies to enable reliable parallel build#2217
Merged
jake-at-work merged 2 commits intoapache:developfrom Jul 30, 2018
Merged
GEODE-5492 Fix gradle dependencies to enable reliable parallel build#2217jake-at-work merged 2 commits intoapache:developfrom
jake-at-work merged 2 commits intoapache:developfrom
Conversation
jake-at-work
requested changes
Jul 28, 2018
geode-core/build.gradle
Outdated
| outputs.file propertiesFile | ||
| inputs.dir "../.git/index" | ||
|
|
||
| mustRunAfter(compileJava) |
Contributor
There was a problem hiding this comment.
This should not be necessary anymore since it only depends on git index.
Author
There was a problem hiding this comment.
Fixed, committed, and rebased to origin/develop
- distZip and distTar tasks wait for all 'jar' tasks to finish - geode-assembly:docs depends on all project's javadoc task - geode-core 'jar' depends on the version properties file - version properties file runs after compileJava - geode-pulse 'war' depends on the webJar, instead of only including it - fixed download of geode-old-versions to run after clean, even when specified backwards on the command line - srcJar no longer includes the IntelliJ output directory Co-authored-by: Patrick Rhomberg <prhomberg@pivotal.io> Co-authored-by: Finn Southerland <fsoutherland@pivotal.io>
Task no longer must run before geode-core:compileJava because it depends on .git/index, not sources Signed-off-by: Dick Cavender <dcavender@pivotal.io>
ghost
force-pushed
the
feature/GEODE-5492
branch
from
9df70f0 to
a8deb73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specified backwards on the command line
Co-authored-by: Patrick Rhomberg prhomberg@pivotal.io
Co-authored-by: Finn Southerland fsoutherland@pivotal.io
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.