GEODE-5609: Extract validateRegionName and improve testing#2353
Merged
kirklund merged 2 commits intoapache:developfrom Aug 21, 2018
Merged
GEODE-5609: Extract validateRegionName and improve testing#2353kirklund merged 2 commits intoapache:developfrom
kirklund merged 2 commits intoapache:developfrom
Conversation
* Extract validateRegionName from LocalRegion to RegionNameValidation * Move and rename RegionNameValidationJUnitTest * Rewrite RegionNameValidationTest with AssertJ and modern testing
kirklund
requested review from
dschneider-pivotal,
jake-at-work,
pdxrunner and
sboorlagadda
dschneider-pivotal
approved these changes
Aug 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new tests prove that GEODE-5609 does not exist as filed.