Skip to content

Conversation

@dschneider-pivotal
Copy link
Contributor

This is a major rewrite of RegionMapDestroyTest. The test was changed enough that I doubt the diffs will be helpful. I changed it to use mocks except for the class under test.
Each test method now has the pattern "given, do, verify".
This unit test now covers 90% of the class (used to be 60%) and the uncovered code is debug logging and what I think is dead code.

I made one small change to the product to use "putEntryIfAbsent" instead of "getEntryMap().putIfAbsent".

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@dschneider-pivotal
Copy link
Contributor Author

the integrationTest failure was a timeout and I see that other ci runs also had this issue. Since all this PR does is modify a unit test, I'm not going to hold it up the integrationTest timeout.

@dschneider-pivotal dschneider-pivotal merged commit ba05178 into apache:develop Sep 7, 2018
@dschneider-pivotal dschneider-pivotal deleted the feature/GEODE-5574 branch September 7, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants