-
Notifications
You must be signed in to change notification settings - Fork 695
GEODE-5574: unit test coverage for RegionMapDestroy #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dschneider-pivotal
merged 20 commits into
apache:develop
from
dschneider-pivotal:feature/GEODE-5574
Sep 7, 2018
Merged
GEODE-5574: unit test coverage for RegionMapDestroy #2431
dschneider-pivotal
merged 20 commits into
apache:develop
from
dschneider-pivotal:feature/GEODE-5574
Sep 7, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent since it does the same thing as the lower level ConcurrentMap putIfAbsent but makes the mocking in the unit test easier
Contributor
Author
|
the integrationTest failure was a timeout and I see that other ci runs also had this issue. Since all this PR does is modify a unit test, I'm not going to hold it up the integrationTest timeout. |
agingade
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major rewrite of RegionMapDestroyTest. The test was changed enough that I doubt the diffs will be helpful. I changed it to use mocks except for the class under test.
Each test method now has the pattern "given, do, verify".
This unit test now covers 90% of the class (used to be 60%) and the uncovered code is debug logging and what I think is dead code.
I made one small change to the product to use "putEntryIfAbsent" instead of "getEntryMap().putIfAbsent".
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.