GEODE-5741: Modified tests to be independent of environment#2496
Merged
pdxrunner merged 3 commits intoapache:developfrom Sep 25, 2018
Merged
GEODE-5741: Modified tests to be independent of environment#2496pdxrunner merged 3 commits intoapache:developfrom
pdxrunner merged 3 commits intoapache:developfrom
Conversation
Tests using relative paths had depended on running as a user other than root. The tests expceted that file or directpory creation would fail because the user would not have permission to write to filesystem root. A further problem was the several tests had hardcoded '/' in pathnames, which is incompatible with running on Windows. * make tests use relative paths * remove system dependent path separators * move tests that expect directory creation to fail to StartMemberUtilsTest.
pdxrunner
requested review from
WireBaron,
galen-pivotal,
kirklund and
nonbinaryprogrammer
WireBaron
approved these changes
Sep 20, 2018
dhemery
approved these changes
Sep 20, 2018
On entry to the test there may (depending test platform) be a version of geode-core-*.jar on the system classpath, but at an unknown position in the list. Now, a dummy geode-core-*.jar path is inserted in the system classpath at a known, but not the first, position.
Author
|
Pre-checkin DistributedTest failure on the pre-checkin is a known issue - GEODE-5728 with open PR#2507 |
kirklund
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests using relative paths had depended on running as a user other than root.
The tests expceted that file or directpory creation would fail because the user
would not have permission to write to filesystem root.
A further problem was the several tests had hardcoded '/' in pathnames,
which is incompatible with running on Windows.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.