GEODE-2644: Improve GfshParserAutoCompletionTest assertions #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also fixed warnings and replaced \n with LINE_SEPARATOR. |
pdxrunner
reviewed
Sep 28, 2018
| buffer = "change loglevel --loglevel"; | ||
| candidate = parser.complete(buffer); | ||
| assertThat(candidate.size()).isEqualTo(8); | ||
| assertThat(candidate.getCandidates()).hasSize(10); |
There was a problem hiding this comment.
Was this an intentional change (8 changed to 10)? Now looks like it's a hard failure.
Contributor
Author
There was a problem hiding this comment.
Oops. Thanks for catching that. I cherry-picked and missed it.
Improve assertions so that failures in this test can be diagnosed without using the IDE debugger.
kirklund
force-pushed
the
GEODE-2644-Appenders-GfshParserAutoCompletionTest
branch
from
3ab69c0 to
103381f
Compare
kirklund
deleted the
GEODE-2644-Appenders-GfshParserAutoCompletionTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve assertions so that failures in this test can be
diagnosed without using the IDE debugger.
This test is failing on my branch for GEODE-2644 but
the failure messages are very cryptic. This simple change
makes the assertion messages easy to understand. Since
this is valuable on develop, I'd like to merge the test change
to develop.