GEODE-5800: remove redundant casts for DataSerializer.readObject()#2546
GEODE-5800: remove redundant casts for DataSerializer.readObject()#2546galen-pivotal wants to merge 3 commits intoapache:developfrom
DataSerializer.readObject()#2546Conversation
PurelyApplied
left a comment
PurelyApplied
left a comment
There was a problem hiding this comment.
+1 for code cleanup, obviously pending merge conflict resolution and failed test examination. I'm not confident in how AnalyzeSerializablesJUnitTest desire to not break backwards compatibility works in practice.
It also looks like we've let this PR get stale enough that the test failures are a bit strange. It looks like StressNewTest failures were UnitTest failures, but didn't fail in Build. But Build has been replaced by a dedicated UnitTest job in these past three weeks. Still, somewhat concerning that the stress went red where the Build didn't.
onichols-pivotal
left a comment
onichols-pivotal
left a comment
There was a problem hiding this comment.
looks like good clean-up and makes things much more readable
|
@galen-pivotal What you waiting for to merge this change? |
* Cleanup DataSerializer * Remove unneeded types * Remove unneeded casts * Remove unused code
galen-pivotal
force-pushed
the
feature/GEODE-5800
branch
from
f031185 to
74d3fd1
Compare
|
I was waiting on GEODE-6036 (#2997) before fixing sanctioned serializables. I haven't pushed that up yet but will in a minute. |
This will make the test's output anything close to debuggable. I suspect that the test is failing due to its use of randomness but would like to verify that.
|
I'm going to close this until I have more time to devote to cleaning up tests, etc. around this. |
4 participants
and remove unused methods on
InternalDataSerializer.