GEODE-4126: Remove *geode.test.golden#2554
GEODE-4126: Remove *geode.test.golden#2554PurelyApplied wants to merge 1 commit intoapache:developfrom
Conversation
|
As best as I can tell, this package represents a testing framework and parser tester that has long since been antiquated by JUnit integration into our build. Moveover, this package represents much of the tight coupling that blocks / makes very difficult any progress on GEODE-5803. |
kirklund
left a comment
There was a problem hiding this comment.
I was actually thinking of moving these to geode-junit. This is the framework used for testing geode examples. It's currently only used for the old examples. The new examples lack tests.
|
I always forget to check the examples! Well, this might be the fastest I've ever opened, gotten feedback, and closed a ticket. My main concern is that having one module's |
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?[n/a] Have you written or updated unit tests to verify your changes?
[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.