Skip to content

GEODE-4126: Remove *geode.test.golden#2554

Closed
PurelyApplied wants to merge 1 commit intoapache:developfrom
PurelyApplied:geode-4126
Closed

GEODE-4126: Remove *geode.test.golden#2554
PurelyApplied wants to merge 1 commit intoapache:developfrom
PurelyApplied:geode-4126

Conversation

@PurelyApplied
Copy link
Copy Markdown
Member

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • [n/a] Have you written or updated unit tests to verify your changes?

  • [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@PurelyApplied
Copy link
Copy Markdown
Member Author

As best as I can tell, this package represents a testing framework and parser tester that has long since been antiquated by JUnit integration into our build. Moveover, this package represents much of the tight coupling that blocks / makes very difficult any progress on GEODE-5803.

Copy link
Copy Markdown
Contributor

@kirklund kirklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking of moving these to geode-junit. This is the framework used for testing geode examples. It's currently only used for the old examples. The new examples lack tests.

@PurelyApplied
Copy link
Copy Markdown
Member Author

I always forget to check the examples!

Well, this might be the fastest I've ever opened, gotten feedback, and closed a ticket.

My main concern is that having one module's test source set depend on other module's active test source set is a serious anti-pattern in gradle. Moving this to geode-junit:main would be the other solution.

@PurelyApplied PurelyApplied deleted the geode-4126 branch January 9, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants