GEODE-5787: support dunit VM bounce on Windows #2563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirk Lund <klund@apache.org>
sboorlagadda
requested review from
jdeppe-pivotal,
kirklund and
upthewaterspout
Signed-off-by: Sai Boorlagadda <sboorlagadda@pivotal.io>
Signed-off-by: Kirk Lund <klund@apache.org>
kirklund
approved these changes
Oct 8, 2018
Member
Author
|
@jdeppe-pivotal @kirklund I would like to request another review on this PR as it is now passing tests. |
kirklund
requested changes
Oct 22, 2018
kirklund
approved these changes
Nov 12, 2018
Contributor
kirklund
left a comment
kirklund
left a comment
There was a problem hiding this comment.
Sorry if this was waiting on my approval!
Contributor
|
@sboorlagadda are you waiting for something before merging these approved changes, besides resolving conflicts? |
Member
Author
|
@pivotal-jbarrett Yes, I need to just resolve conflicts and this will be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kirk Lund klund@apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.