GEODE-5888: Check partitioned region is ready in bucket region#2645
Merged
pivotal-eshu merged 2 commits intodevelopfrom Oct 23, 2018
Merged
GEODE-5888: Check partitioned region is ready in bucket region#2645pivotal-eshu merged 2 commits intodevelopfrom
pivotal-eshu merged 2 commits intodevelopfrom
Conversation
pivotal-eshu
commented
Oct 17, 2018
pivotal-eshu
commented
- A bulk opertion could remove lockObject due to RegionDestroyedException.
- Do not allow a new operation to proceed without checking region readiness.
…ing. * A bulk opertion could remove lockObject due to RegionDestroyedException. * Do not allow a new operation to proceed without checking region readiness.
pivotal-eshu
requested review from
agingade,
dschneider-pivotal,
gesterzhou,
kirklund and
lgallinat
agingade
reviewed
Oct 17, 2018
| * @return first key found in CM null means not found | ||
| */ | ||
| private LockObject searchAndLock(Object keys[]) { | ||
| LockObject searchAndLock(Object keys[]) { |
There was a problem hiding this comment.
The caller waitUntilLocked() could return a boolean status; indicating lock is successfully acquired; based on that we could clean-up the locks from finally block.
Author
There was a problem hiding this comment.
Thanks for reviewing. Will address your concern.
kirklund
approved these changes
Oct 19, 2018
* rename activeWriteLock to be primaryMoveReadLock as it is a readLock.
agingade
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.