Skip to content

GEODE-5987: Correct issue with powermock leaking JDK11-incompatible d…#2797

Merged
jinmeiliao merged 3 commits intoapache:developfrom
PurelyApplied:geode-5987-rebalancer
Nov 7, 2018
Merged

GEODE-5987: Correct issue with powermock leaking JDK11-incompatible d…#2797
jinmeiliao merged 3 commits intoapache:developfrom
PurelyApplied:geode-5987-rebalancer

Conversation

@PurelyApplied
Copy link
Member

…ependencies.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@PurelyApplied PurelyApplied requested a review from jhuynh1 November 6, 2018 23:55
@PurelyApplied
Copy link
Member Author

This PR is addressing the recent Concourse failure.

It appears that:

  • powermock was leaking its dependencies
  • Mockito as provided by this version of powermock is not JDK11 compatabile
  • powermock is not actually necessary for unit-level testing and may be removed here.
  • Consequently, the actual dependencies should be specified instead.

All the more reason for us to be diligent in keeping our footprint small not leaking dependencies we do not intend to be shared downstream.

Noting that precheckin does not yet test JDK11: locally tested with command

JAVA_HOME="" ./gradlew geode-rebalancer:test --tests AutoBalancerJUnitTest -PtestJVM=/path/to/.jenv/versions/11.0 -PforceTest=true

@PurelyApplied
Copy link
Member Author

[Comment bump to bump the Concourse dunit bumpity bump.]

@jinmeiliao jinmeiliao merged commit 083abbc into apache:develop Nov 7, 2018
@jinmeiliao jinmeiliao deleted the geode-5987-rebalancer branch November 7, 2018 21:47
@PurelyApplied PurelyApplied restored the geode-5987-rebalancer branch December 3, 2018 17:59
@PurelyApplied PurelyApplied deleted the geode-5987-rebalancer branch January 9, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants