GEODE-6014: Removed unnecessary null checks.#2813
Merged
nabarunnag merged 1 commit intoapache:developfrom Nov 14, 2018
Merged
Conversation
nabarunnag
requested review from
bschuchardt,
jhuynh1,
ladyVader and
mcmellawatt
bschuchardt
reviewed
Nov 9, 2018
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/concurrent/CompactConcurrentHashSet2.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/concurrent/CompactConcurrentHashSet2.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/internal/concurrent/CompactConcurrentHashSet2.java
Show resolved
Hide resolved
nabarunnag
force-pushed
the
feature/GEODE-6014
branch
from
bac16aa to
d92fce6
Compare
mcmellawatt
reviewed
Nov 13, 2018
Contributor
mcmellawatt
left a comment
mcmellawatt
left a comment
There was a problem hiding this comment.
Just curious how we identified that these null checks are no longer necessary? Were this found through static analysis/IntelliJ tools? Or did you carefully comb through and determine there is no way that these variables could be null?
geode-core/src/main/java/org/apache/geode/internal/cache/FilterProfile.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ReadWriteFile.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mcmellawatt These were initially flagged by LGTM, but they were reviewed in the code. If you load the diff using an IDE you can see the reason why these values can't be null |
nabarunnag
force-pushed
the
feature/GEODE-6014
branch
from
d92fce6 to
acce1b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.