GEODE-5971: Refactor durable client commands to extend GfshCommand#2858
Merged
jdeppe-pivotal merged 3 commits intoapache:developfrom Nov 16, 2018
Conversation
jinmeiliao
requested changes
Nov 15, 2018
| params[1] = cqName; | ||
|
|
||
| final ResultCollector<?, ?> rc = | ||
| CliUtil.executeFunction(new CloseDurableCqFunction(), params, targetMembers); |
Member
There was a problem hiding this comment.
I think we are trying to get away from using CliUtils in the command
| Properties props = new Properties(); | ||
| props.setProperty(LOG_LEVEL, "fine"); | ||
| props.setProperty(ConfigurationProperties.JMX_MANAGER_HOSTNAME_FOR_CLIENTS, "localhost"); | ||
| props.setProperty(ConfigurationProperties.JMX_MANAGER_PORT, "" + jmxPort); |
Member
There was a problem hiding this comment.
I don't think these properties are needed.
Contributor
Author
There was a problem hiding this comment.
Yes - removed.
| String commandString = csb.toString(); | ||
|
|
||
| gfsh.executeAndAssertThat(commandString).statusIsError() | ||
| .tableHasColumnWithExactValuesInAnyOrder("CQ Name", |
Member
There was a problem hiding this comment.
I think we should deprecate these methods in CommandResultAssert. these are used for the old CommandResult, for the ResultModel, the other assertions are much easier to understand.
jdeppe-pivotal
force-pushed
the
feature/GEODE-5971-refactor-durable-client-commands
branch
from
de8c79a to
031b7c2
Compare
jinmeiliao
approved these changes
Nov 15, 2018
jdeppe-pivotal
deleted the
feature/GEODE-5971-refactor-durable-client-commands
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.