GEODE-5076 jmx client should not access or modify internal regions#2866
Closed
bschuchardt wants to merge 6 commits intodevelopfrom
Closed
GEODE-5076 jmx client should not access or modify internal regions#2866bschuchardt wants to merge 6 commits intodevelopfrom
bschuchardt wants to merge 6 commits intodevelopfrom
Conversation
Modified the management packages to use a filtered cache that doesn't allow users access to internal regions.
Fixes for failing unit tests. An InternalCacheForClientAccess wasn't being used consistently and some parts of the management code use the cache as a key in a Map.
Added a gfsh test that tries to update PdxTypes with a "put" command and fixed a bug it exposed.
kirklund
reviewed
Nov 19, 2018
Contributor
kirklund
left a comment
kirklund
left a comment
There was a problem hiding this comment.
I recommend changing any Function code to use FunctionContext.getCache(). I only added a comment to one of these in the review, but it would be good to handle them all the same way.
geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocator.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/management/internal/beans/CacheServerBridge.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/management/internal/cli/modes/CommandModes.java
Outdated
Show resolved
Hide resolved
Addressing Kirk's review comments and fixing a problem with gfsh "export logs".
Adding additional mocks to a couple of UnitTest tests.
empty commit to trigger another build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the management packages to use a filtered cache that doesn't
allow users access to internal regions.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.