Skip to content

Update javadocs for data-source pool classes#2870

Merged
jchen21 merged 1 commit intoapache:developfrom
gemzdude:feature/GEODE-6071
Nov 21, 2018
Merged

Update javadocs for data-source pool classes#2870
jchen21 merged 1 commit intoapache:developfrom
gemzdude:feature/GEODE-6071

Conversation

@gemzdude
Copy link
Copy Markdown
Contributor

Also fix parameter name in CreateDataSourceCommand

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Also fix parameter name in CreateDataSourceCommand
Copy link
Copy Markdown
Contributor

@onichols-pivotal onichols-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@davebarnes97 davebarnes97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Optional grammar nit: "only valid when" should be "valid only when". (2 occurrences - not a big deal, so optional)

@jchen21 jchen21 merged commit 5f53d53 into apache:develop Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants