GEODE-6143: Remove PowerMock from ExecuteFunction tests#3045
Merged
kirklund merged 3 commits intoapache:developfrom Jan 3, 2019
Merged
GEODE-6143: Remove PowerMock from ExecuteFunction tests#3045kirklund merged 3 commits intoapache:developfrom
kirklund merged 3 commits intoapache:developfrom
Conversation
Remove PowerMock from: * ExecuteFunctionTest * ExecuteFunction65Test * ExecuteFunction66Test Add test for ExecuteFunction70Test by subclasses ExecuteFunction66Test.
Petahhh
approved these changes
Jan 2, 2019
Contributor
Petahhh
left a comment
Petahhh
left a comment
There was a problem hiding this comment.
I really like how you reorganized the tests. Must easier to read this way =)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove PowerMock from:
Add test for ExecuteFunction70Test by subclasses ExecuteFunction66Test.
There are two commits. 1st commit is the main one to review. 2nd and 3rd commits fix some log statements, reduce IDE warnings, etc.