GEODE-6253: Handle JDK-8207200 gracefully in VM stats#3057
Merged
kirklund merged 1 commit intoapache:developfrom Jan 8, 2019
Merged
GEODE-6253: Handle JDK-8207200 gracefully in VM stats#3057kirklund merged 1 commit intoapache:developfrom
kirklund merged 1 commit intoapache:developfrom
Conversation
| try { | ||
| return memBean.getHeapMemoryUsage(); | ||
| } catch (IllegalArgumentException e) { | ||
| logger.info("JDK-8207200 prevented sampling stats for HeapMemoryUsage"); |
Contributor
There was a problem hiding this comment.
I'm concerned that this will log every second (each time a sample is done). Could you add a count somewhere and only log the message once?
Contributor
Author
There was a problem hiding this comment.
I had changed it to debug but it was in the 2nd commit. I've dropped the 2nd commit and fixed up the 1st commit so you can see it's debug now.
kirklund
force-pushed
the
GEODE-6253-VMStats50
branch
from
86257b9 to
3131e93
Compare
dschneider-pivotal
approved these changes
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit prevents logging of a fatal level stack trace when JDK-8207200 is hit and allows remaining stats to be sampled.