Stable pdx instance (not yet ready for review)#3072
Closed
dschneider-pivotal wants to merge 5 commits intoapache:developfrom
Closed
Stable pdx instance (not yet ready for review)#3072dschneider-pivotal wants to merge 5 commits intoapache:developfrom
dschneider-pivotal wants to merge 5 commits intoapache:developfrom
Conversation
Also this interface is now implemented by the pdx enum classes. So now all classes that implement PdxInstance also implement InternalPdxInstance
A method that was on PdxInstanceImpl but only used by AttributeDescriptor and that did not use any PdxInstanceImpl data is now on AttributeDescriptor. This also got rid of a singleton lookup of the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not review. Refactoring some pdx code to investigate adding a new PdxInstance implementation that could be safely used as a region key.