Skip to content

GEODE-6275: Fail when benchmark pipes fails.#3077

Merged
nonbinaryprogrammer merged 2 commits intoapache:developfrom
nonbinaryprogrammer:GEODE-6275
Jan 15, 2019
Merged

GEODE-6275: Fail when benchmark pipes fails.#3077
nonbinaryprogrammer merged 2 commits intoapache:developfrom
nonbinaryprogrammer:GEODE-6275

Conversation

@nonbinaryprogrammer
Copy link
Copy Markdown
Contributor

@nonbinaryprogrammer nonbinaryprogrammer commented Jan 15, 2019

Signed-off-by: Helena A. Bales hbales@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Signed-off-by: Helena A. Bales <hbales@pivotal.io>
Signed-off-by: Jacob Barrett <jbarrett@pivotal.io>
Copy link
Copy Markdown
Contributor

@smgoller smgoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nonbinaryprogrammer nonbinaryprogrammer merged commit 3a190d3 into apache:develop Jan 15, 2019
@nonbinaryprogrammer nonbinaryprogrammer deleted the GEODE-6275 branch January 15, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants