GEODE-6301: Use ThreadInfo.toString in ExecutorServiceRule.dumpThreads#3123
Merged
kirklund merged 1 commit intoapache:developfrom Feb 4, 2019
Conversation
Cleanup javadocs and warnings in all ExecutorServiceRule tests.
kirklund
force-pushed
the
GEODE-6301-ExecutorServiceRule-format-dumpThreads
branch
from
6d9ff5d to
e850f57
Compare
Contributor
|
Wow! Those tests look very helpful! |
dschneider-pivotal
approved these changes
Feb 4, 2019
demery-pivotal
approved these changes
Feb 4, 2019
|
|
||
| assertThat(dump) | ||
| .contains("Number of locked synchronizers = 2") | ||
| .contains(sync.getClass().getName() + "$NonfairSync@"); |
Contributor
There was a problem hiding this comment.
Is there something in this test that requires it to be a non-fair sync? If so, I'd like the test to indicate more clearly why it's non-fair. If this inner class name is just an implementation detail, consider ignoring the inner class name by comparing via regex.
Similar for other comparisons involving inner class names.
Contributor
Author
There was a problem hiding this comment.
Oops, I merged to develop before refreshing the page. I'll file another PR with removal of hard-coded inner-classes from the assertions. The only reason it's there is to assert that the class is in the thread stack.
jake-at-work
approved these changes
Feb 4, 2019
bschuchardt
approved these changes
Feb 4, 2019
kirklund
deleted the
GEODE-6301-ExecutorServiceRule-format-dumpThreads
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadInfo.toString contains all of the relevant monitor/synchronizer lock info that ExecutorServiceRule.dumpThreads needs so I removed customization of the dump and just use what ThreadInfo provides.