Skip to content

GEODE-6340: use new cli options for benchmarks#3148

Merged
nonbinaryprogrammer merged 3 commits intoapache:developfrom
nonbinaryprogrammer:GEODE-6340
Feb 11, 2019
Merged

GEODE-6340: use new cli options for benchmarks#3148
nonbinaryprogrammer merged 3 commits intoapache:developfrom
nonbinaryprogrammer:GEODE-6340

Conversation

@nonbinaryprogrammer
Copy link
Copy Markdown
Contributor

  • change geode benchmark branch from -m to -e
  • use the new -m option to specify metadata for ci runs of benchmarks

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

* change geode benchmark branch from -m to -e
* use the new -m option to specify metadata for ci runs of benchmarks
@nonbinaryprogrammer
Copy link
Copy Markdown
Contributor Author

The unit test that failed is the one that is currently failing in the main pipeline

@nonbinaryprogrammer nonbinaryprogrammer merged commit 83fc3e2 into apache:develop Feb 11, 2019
@nonbinaryprogrammer nonbinaryprogrammer deleted the GEODE-6340 branch February 11, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants