GEODE-6379: track departed members to avoid processing in-flight lock request#3176
Merged
pivotal-eshu merged 6 commits intodevelopfrom Feb 26, 2019
Merged
GEODE-6379: track departed members to avoid processing in-flight lock request#3176pivotal-eshu merged 6 commits intodevelopfrom
pivotal-eshu merged 6 commits intodevelopfrom
Conversation
pivotal-eshu
requested review from
dschneider-pivotal,
kirklund and
lgallinat
added 2 commits
February 8, 2019 11:11
dschneider-pivotal
requested changes
Feb 13, 2019
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
Outdated
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
Show resolved
Hide resolved
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockGrantor.java
Outdated
Show resolved
Hide resolved
kirklund
reviewed
Feb 15, 2019
Contributor
kirklund
left a comment
kirklund
left a comment
There was a problem hiding this comment.
In theory, the dlockservice used to handle this case and never process lock requests for departed members. I'm not sure if the code changed to open up this hole or not. I suspect there is or was some synchronization with the MembershipListener in the DLockGrantor that prevents this. Maybe regular dlocks don't have this hole but txlocks do.
dschneider-pivotal
approved these changes
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.