GEODE-5013 Replace org.json with Jackson in GfJsonObject#3288
Closed
bschuchardt wants to merge 8 commits intodevelopfrom
Closed
GEODE-5013 Replace org.json with Jackson in GfJsonObject#3288bschuchardt wants to merge 8 commits intodevelopfrom
bschuchardt wants to merge 8 commits intodevelopfrom
Conversation
This removes org.json as a dependency in geode-core and associated test modules. GfJsonObject and GfJsonArray are ported to use the same basic Jackson ObjectMapper setup as QueryResultFormatter so that we now have a uniform mechanism for managing JSON documents for querying/gfsh. The geode-web-api and geode-pulse modules still use the geode-json module. When/if they are ported to use GfJsonObject/Array we can delete the geode-json module.
bschuchardt
requested review from
agingade,
jdeppe-pivotal,
lgallinat and
nabarunnag
agingade
approved these changes
Mar 14, 2019
| compile('com.healthmarketscience.rmiio:rmiio') | ||
|
|
||
| compile(project(':geode-common')) | ||
| compile(project(':geode-json')) |
There was a problem hiding this comment.
Removing this line; will this impact building geode-web-api and geode-pulse?
Contributor
Author
There was a problem hiding this comment.
The geode-web-api includes geode-json as a dependency. There are tickets for getting rid of it there and in geode-pulse.
| try { | ||
| assertThat(launcher.status().getStatus()).isEqualTo(Status.ONLINE); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
| gen.writeEndObject(); | ||
| } | ||
|
|
||
| void _serialize(Collection value, JsonGenerator gen) throws IOException { |
There was a problem hiding this comment.
remove underscore from method name....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes org.json as a dependency in geode-core and associated test
modules. GfJsonObject and GfJsonArray are ported to use the same basic
Jackson ObjectMapper setup as QueryResultFormatter so that we now have a
uniform mechanism for managing JSON documents for querying/gfsh.
The geode-web-api and geode-pulse modules still use the geode-json
module. When/if they are ported to use GfJsonObject/Array we can delete
the geode-json module.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.