Skip to content

GEODE-6513: Revised README and BUILDING#3292

Merged
1 commit merged intoapache:developfrom
robbadler:GEODE-6513
Mar 21, 2019
Merged

GEODE-6513: Revised README and BUILDING#3292
1 commit merged intoapache:developfrom
robbadler:GEODE-6513

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 12, 2019

  • Better IntelliJ integration via 'Before Executing' triggers with
    Gradle.
  • Added screenshot of IntelliJ configuration.
  • Replaced old Travis badge with Concourse
  • Remove stale reference to Travis in PR template, replace with
    concourse
  • Grammar fixes in README

Authored-by: Robert Houghton rhoughton@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

* Better IntelliJ integration via 'Before Executing' triggers with
Gradle.
* Added screenshot of IntelliJ configuration.
* Replaced old Travis badge with Concourse
* Remove stale reference to Travis in PR template, replace with
concourse
* Grammar fixes in README

Authored-by: Robert Houghton <rhoughton@pivotal.io>
@ghost ghost requested review from PurelyApplied and metatype March 12, 2019 19:02

1. Run `./gradlew --parallel devBuild` from Geode repository root to create compiler generated source
1. Run `./gradlew --parallel generate` from Geode repository root to create compiler generated source.
1. Alternatively (and to ensure these sources stay up-to-date):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth having the alternative listed here or just putting one opinionated way? When following this on a fresh clone I didn't like skipping to step 2 to come back to step 1 (but I'm bad at following directions, so likely a me problem).


[![Build Status](https://travis-ci.org/apache/geode.svg?branch=develop)](https://travis-ci.org/apache/geode) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0) [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.apache.geode/geode-core/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.geode%22) [![homebrew](https://img.shields.io/homebrew/v/apache-geode.svg)](http://brewformulas.org/ApacheGeode) [![Docker Pulls](https://img.shields.io/docker/pulls/apachegeode/geode.svg)](https://hub.docker.com/r/apachegeode/geode/)

[![Build Status](https://concourse.apachegeode-ci.info/api/v1/teams/main/pipelines/apache-develop-main/jobs/Build/badge)](https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0) [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.apache.geode/geode-core/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.geode%22) [![homebrew](https://img.shields.io/homebrew/v/apache-geode.svg)](http://brewformulas.org/ApacheGeode) [![Docker Pulls](https://img.shields.io/docker/pulls/apachegeode/geode.svg)](https://hub.docker.com/r/apachegeode/geode/)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, a link that goes where I want to go!

@ghost ghost merged commit 301700d into apache:develop Mar 21, 2019
@ghost ghost deleted the GEODE-6513 branch June 23, 2020 17:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants