GEODE-5971: refactor RebalanceCommand to use ResultModel#3303
Merged
jinmeiliao merged 3 commits intoapache:developfrom Mar 21, 2019
Merged
GEODE-5971: refactor RebalanceCommand to use ResultModel#3303jinmeiliao merged 3 commits intoapache:developfrom
jinmeiliao merged 3 commits intoapache:developfrom
Conversation
Member
Author
| } | ||
|
|
||
| // if the result contains only error section, then we need to mark the result as error status | ||
| if (result.getSection("error") != null && result.getSectionSize() == 1) { |
Contributor
There was a problem hiding this comment.
This seems inconsistent with our overall stance that even a single member error would result in the overall command returning an error.
Member
Author
There was a problem hiding this comment.
I am trying not to change the old behavior. This seems like the only way to make sure of that...
Contributor
There was a problem hiding this comment.
Is this an edge case? It would be nice if the comment gave some example of how you might end up with exactly 1 error section and no other sections, as well as mention other path(s) by which error status is set and why those existing codepaths are not able to cover this one edge case.
Member
Author
There was a problem hiding this comment.
comments added to explain the reason to do it this way.
jdeppe-pivotal
approved these changes
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.