GEODE-6526: Removing call to removeTombstone during entry destroy#3348
Merged
agingade merged 3 commits intoapache:developfrom Mar 26, 2019
Merged
GEODE-6526: Removing call to removeTombstone during entry destroy#3348agingade merged 3 commits intoapache:developfrom
agingade merged 3 commits intoapache:developfrom
Conversation
During destroy entry (tombstone) under region entry lock, if the entry had a lower region version than the recorded gc version for that member, the entry was removed immediately which could result in dead-lock with tombstone gc thread. Instead of removing the entry during destroy, it was scheduled to remove during tombstone gc.
agingade
requested review from
bschuchardt,
dschneider-pivotal,
gesterzhou,
lgallinat and
nabarunnag
bschuchardt
reviewed
Mar 22, 2019
added 2 commits
March 22, 2019 15:54
bschuchardt
approved these changes
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During destroy entry (tombstone) under region entry lock, if the
entry had a lower region version than the recorded gc version for
that member, the entry was removed immediately which could result
in dead-lock with tombstone gc thread.
Instead of removing the entry during destroy, it was scheduled to
remove during tombstone gc.
For all changes:
[Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?[Y] Is your initial contribution a single, squashed commit?
[Y] Does
gradlew buildrun cleanly?[Y] Have you written or updated unit tests to verify your changes?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.