GEODE-6557: Moving geode-web classes to geode-web#3351
Merged
upthewaterspout merged 3 commits intoapache:developfrom Mar 27, 2019
Merged
GEODE-6557: Moving geode-web classes to geode-web#3351upthewaterspout merged 3 commits intoapache:developfrom
upthewaterspout merged 3 commits intoapache:developfrom
Conversation
upthewaterspout
force-pushed
the
feature/move-admin-web-GEODE-6557
branch
from
1edaeaa to
3e209a7
Compare
Moving the classes in geode-core that really should be in geode-web. This removes optional dependencies from geode-core and puts these classes where their tests are. As part of this change, SerializableObjectHttpMessageConverter is now duplicated in geode-web as ServerSerializableObjectHttpMessageConverter. This class was previously put in both the geode-web.war file and the gfsh-dependencies by creating a separate jar with all of the geode-web classes as part of the geode-core build. This class is used by both gfsh and geode-web. But geode-web needs its own copy so that the class is loaded by the geode-web war classloader in order to ensure the class is linked with the spring-web classes coming from the geode-web classloader.
upthewaterspout
force-pushed
the
feature/move-admin-web-GEODE-6557
branch
from
3e209a7 to
658d711
Compare
jdeppe-pivotal
approved these changes
Mar 26, 2019
Contributor
jdeppe-pivotal
left a comment
jdeppe-pivotal
left a comment
There was a problem hiding this comment.
LGTM - I tried (not very hard) removing ServerSerializableObjectHttpMessageConverter altogether but I think it's required for some gfsh query functionality.
ghost
suggested changes
Mar 27, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I love this refactor. Small change to prefer xyzTestImplementation over xyzTestCompile
Applying review comments and using implementation instead of compile for test dependencies.
ghost
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.