GEODE-4240: Fixup DeprecatedCacheServerLauncherIntegrationTest#3645
Merged
kirklund merged 3 commits intoapache:developfrom May 29, 2019
Merged
Conversation
* Use GeodeAwaitility timeout * Specify HTTP_SERVICE_PORT=0 * Use ConfigurationProperties constants
moleske
approved these changes
May 29, 2019
Member
moleske
left a comment
moleske
left a comment
There was a problem hiding this comment.
Thanks for doing cleanup, makes it easier to follow!
| public class DeprecatedCacheServerLauncherIntegrationTest { | ||
| private static final Logger logger = LogService.getLogger(); | ||
|
|
||
| private static final long TIMEOUT_MILLIS = GeodeAwaitility.getTimeout().getValueInMS(); |
Member
There was a problem hiding this comment.
Thanks for switching to the consistent timeout!
| } | ||
|
|
||
| private void execAndValidate(final String regex, final String... args) | ||
| private void execWithArgsAndValidate(Operation operation, String regex, List<String> arguments) |
Member
There was a problem hiding this comment.
I like having this broken out, makes it easier to read with specific functions
kirklund
deleted the
GEODE-4240-DeprecatedCacheServerLauncherIntegrationTest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.