GEODE-6867: Updating Tomcat Session State Module docs#3886
GEODE-6867: Updating Tomcat Session State Module docs#3886gesterzhou merged 3 commits intoapache:developfrom
Conversation
davebarnes97
left a comment
There was a problem hiding this comment.
Descriptive text looks fine. Alerts about updating the corresponding user guide passages may be helpful, but one wonders if they're truly necessary. Shouldn't developers always check behavioral changes against the documentation? Never mind, silly question :)
I agree in an ideal world this shouldn't happen, but the truth is it already did (which prompted part of this PR). Someone saw new dependencies were added which caused a test to fail, so they fixed the test but the documentation remained stale. Any hints we can give to someone who is fixing a broken test to also fix the documentation doesn't hurt ;P. |
kirklund
left a comment
There was a problem hiding this comment.
I think I'll be updating this soon as well!
This reverts commit b31d9f3.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?[N/A] Have you written or updated unit tests to verify your changes?
[N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.