Skip to content

GEODE-6867: Updating Tomcat Session State Module docs#3886

Merged
gesterzhou merged 3 commits intoapache:developfrom
mcmellawatt:feature/GEODE-6867
Aug 30, 2019
Merged

GEODE-6867: Updating Tomcat Session State Module docs#3886
gesterzhou merged 3 commits intoapache:developfrom
mcmellawatt:feature/GEODE-6867

Conversation

@mcmellawatt
Copy link
Contributor

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • [N/A] Have you written or updated unit tests to verify your changes?

  • [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Copy link
Contributor

@davebarnes97 davebarnes97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptive text looks fine. Alerts about updating the corresponding user guide passages may be helpful, but one wonders if they're truly necessary. Shouldn't developers always check behavioral changes against the documentation? Never mind, silly question :)

@mcmellawatt
Copy link
Contributor Author

Descriptive text looks fine. Alerts about updating the corresponding user guide passages may be helpful, but one wonders if they're truly necessary. Shouldn't developers always check behavioral changes against the documentation? Never mind, silly question :)

I agree in an ideal world this shouldn't happen, but the truth is it already did (which prompted part of this PR). Someone saw new dependencies were added which caused a test to fail, so they fixed the test but the documentation remained stale. Any hints we can give to someone who is fixing a broken test to also fix the documentation doesn't hurt ;P.

Copy link
Contributor

@kirklund kirklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll be updating this soon as well!

@gesterzhou gesterzhou merged commit b31d9f3 into apache:develop Aug 30, 2019
mcmellawatt added a commit that referenced this pull request Sep 6, 2019
bschuchardt added a commit that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants