GEODE-7177: Logging as a submodule#4129
Merged
echobravopapa merged 3 commits intoapache:developfrom Oct 10, 2019
Merged
Conversation
kirklund
approved these changes
Oct 8, 2019
- Extracting LogService and it's dependencies to a separate geode-logging submodule so that other modules not in geode-core can still use LogService to get a Logger. - Removing the use of the logging SPI from LogService LogService had a dependency on the logging SPI in geode-core. However, this dependency was unecessary - the LoggingProvider loaded statically in this class never had `configure` called on it. In addition, the getLogger methods of this class are merely creating FastLoggers which can live inside geode-logging and do not need to be pluggable. - Moved executors that are not dependent on geode-core to geode-logging and renamed the remaining executors to be CoreLoggingExecutors. - Refactor the marker interface from Loggable to EntriesCollection
- EntriesCollection put back into internal.cache and AbstractRegion now implements the marker - Formerly known as Loggable renamed to LogWithToString
echobravopapa
force-pushed
the
fix/take2-GEODE-7172-7177
branch
from
56bbcd8 to
ee7953c
Compare
…with LogWithToString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.