GEODE-7291: Prevent empty micrometer tags#4156
Merged
kirklund merged 1 commit intoapache:developfrom Oct 17, 2019
Merged
Conversation
kirklund
force-pushed
the
ClientCache-micrometer-common-tags
branch
2 times, most recently
from
862a46c to
e9dbb48
Compare
* Do not include member meter tag if member name is missing * Do not include cluster meter tags in a client Co-authored-by: Aaron Lindsey <alindsey@pivotal.io>
kirklund
force-pushed
the
ClientCache-micrometer-common-tags
branch
from
e9dbb48 to
80ad128
Compare
kirklund
changed the title
kirklund
changed the title
demery-pivotal
approved these changes
Oct 14, 2019
Contributor
demery-pivotal
left a comment
demery-pivotal
left a comment
There was a problem hiding this comment.
Maybe soon I (or someone) can add hasNoTagNamed(…) to AbstractMeterAssert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Aaron Lindsey alindsey@pivotal.io
Please review @aaronlindsey