Skip to content

GEODE-6993: Add documentation for alter query-service gfsh command#4323

Merged
davebarnes97 merged 4 commits intoapache:developfrom
DonalEvans:feature/GEODE-6993
Nov 21, 2019
Merged

GEODE-6993: Add documentation for alter query-service gfsh command#4323
davebarnes97 merged 4 commits intoapache:developfrom
DonalEvans:feature/GEODE-6993

Conversation

@DonalEvans
Copy link
Copy Markdown
Contributor

Co-authored-by: Benjamin Ross bross@pivotal.io
Co-authored-by: Donal Evans doevans@pivotal.io

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Co-authored-by: Benjamin Ross <bross@pivotal.io>
Co-authored-by: Donal Evans <doevans@pivotal.io>
@davebarnes97
Copy link
Copy Markdown
Contributor

Thanks for contributing docs!
A small request: in alter.html.md.erb, in the phrase: "...parsing of the parameter string which makes using..." please add a comma after "string": "...string, which..."

Co-authored-by: Benjamin Ross <bross@pivotal.io>
Co-authored-by: Donal Evans <doevans@pivotal.io>
@DonalEvans
Copy link
Copy Markdown
Contributor Author

Thanks for contributing docs!
A small request: in alter.html.md.erb, in the phrase: "...parsing of the parameter string which makes using..." please add a comma after "string": "...string, which..."

Done!

Donal Evans and others added 2 commits November 14, 2019 16:01
Co-authored-by: Donal Evans <doevans@pivotal.io>
Co-authored-by: Benjamin Ross <bross@pivotal.io>
Co-authored-by: Donal Evans <doevans@pivotal.io>
Co-authored-by: Benjamin Ross <bross@pivotal.io>
Copy link
Copy Markdown
Contributor

@davebarnes97 davebarnes97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The passage that concerned me was deleted along with the option it described.
No further objection, your honor.

@davebarnes97 davebarnes97 merged commit dc80b73 into apache:develop Nov 21, 2019
@DonalEvans DonalEvans deleted the feature/GEODE-6993 branch January 22, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants