GEODE-7597: Factor out code needed in Membership from SocketCreator#4637
Merged
bschuchardt merged 7 commits intodevelopfrom Jan 29, 2020
Merged
GEODE-7597: Factor out code needed in Membership from SocketCreator#4637bschuchardt merged 7 commits intodevelopfrom
bschuchardt merged 7 commits intodevelopfrom
Conversation
bschuchardt
force-pushed
the
feature/GEODE-7597
branch
from
31ea0bf to
192c32f
Compare
upthewaterspout
approved these changes
Jan 28, 2020
.../java/org/apache/geode/distributed/internal/membership/gms/MembershipLocatorBuilderImpl.java
Outdated
Show resolved
Hide resolved
Implemented a new TcpSocketCreatorImpl. Due to GeodeHttpClientRule dependencies this and associated interfaces are in geode-common. I'd rather have them in geode-tcp-server. SocketCreator now subclasses TcpSocketCreatorImpl and I've removed the adapter class, which is no longer needed.
bschuchardt
force-pushed
the
feature/GEODE-7597
branch
from
9aa351f to
5106283
Compare
mhansonp
pushed a commit
to mhansonp/geode
that referenced
this pull request
Mar 12, 2020
…pache#4637) * GEODE-7597: Factor out code needed in Membership from SocketCreator Implemented a new TcpSocketCreatorImpl. Due to GeodeHttpClientRule dependencies this and associated interfaces are in geode-common. I'd rather have them in geode-tcp-server. SocketCreator now subclasses TcpSocketCreatorImpl and I've removed the adapter class, which is no longer needed. * added missing files * fixing dunit failure and moving TcpSocketCreator back to the tcp-server project * fixing bind address and inheritance problems in socket creators * fixes for unit test failures * spotless * relax assertion in test that fails stress-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a new TcpSocketCreatorImpl. Due to GeodeHttpClientRule
dependencies this and associated interfaces are in geode-common. I'd
rather have them in geode-tcp-server.
SocketCreator now subclasses TcpSocketCreatorImpl and I've removed the
adapter class, which is no longer needed.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.