GEODE-8024: fix wan test to also work on support branches#4997
Merged
onichols-pivotal merged 1 commit intoapache:developfrom Apr 25, 2020
Conversation
dickcav
approved these changes
Apr 25, 2020
onichols-pivotal
added a commit
that referenced
this pull request
Apr 25, 2020
(cherry picked from commit 8e68aba)
onichols-pivotal
deleted the
GEODE-8024-fix-wan-test-to-also-work-on-support-branches
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test assumed old version and current version will always be incompatible, but on a support branch, old version can be 1.12.0 and current can be 1.12.1 which both have the same serialization version, so changed the test to expect success rather than failure when major and minor are same