GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87 #5382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirklund
force-pushed
the
GEODE-8368-ClassGraph-4.8.87
branch
2 times, most recently
from
67a9f88 to
08a864e
Compare
Contributor
|
Out of curiosity what are we changing this? Was there a specific issue with 4.8.52 you are trying to solve? I would much rather go back to 4.0.6 and fix the log4j issue with an exclusion, than mess around with any of these newfangled versions. |
kirklund
force-pushed
the
GEODE-8368-ClassGraph-4.8.87
branch
from
08a864e to
9e97e37
Compare
Contributor
Author
|
@onichols-pivotal ClassGraph has nothing to do with Log4j. I analyzed a test run in which a thread hung in ClassGraph#scan. ClassGraph has had many bugs identified and fixed between 4.8.52 and 4.8.87. I believe that a dependency like this should be kept up to date especially when important bugs have been fixed. |
Contributor
Author
|
I don't have time for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade ClassGraph dependency from 4.8.52 to 4.8.87.
See GEODE-8150. There were performance issues with 4.8.78 that caused us to rollback to 4.8.52. We'll need to do extra testing as well as review of ClassGraph release notes and bugs.
The intention is to review and fully test any new release of ClassGraph with bug fixes to determine if it's worth upgrading the dependency in Geode. If it introduces new problems or doesn't offer any improvements, we won't upgrade. If it's more stable and fixes bugs in ClassGraph that Geode is vulnerable to, then I will recommend upgrading.
ClassGraph release notes: https://github.com/classgraph/classgraph/releases
ClassGraph closed bugs: https://github.com/classgraph/classgraph/issues?q=is%3Aissue+is%3Aclosed
CAUTION: Please don't merge this PR for me!