GEODE-8382: Run Redis tests against Redis API for Geode#5416
Conversation
|
Tested new pipeline job here: https://concourse.gemfire-ci.info/teams/developer/pipelines/sabbeypivotal-pipelining-pr |
|
The pipeline linked is not publicly viewable, so it is harder to assert that it is indeed working |
Good point, Mike. The pipeline was tested locally, feel free to deploy a local version to make sure it works. |
|
@smgoller @rhoughton-pivot @onichols-pivotal @dickcav |
onichols-pivotal
left a comment
onichols-pivotal
left a comment
There was a problem hiding this comment.
looks great to me
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Change the RAM amount, then I say ship it!
onichols-pivotal
left a comment
onichols-pivotal
left a comment
There was a problem hiding this comment.
the fixups look great @sabbeyPivotal thanks!
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
The changes are good. I can't think of a better way to set the JAVA_TEST_PATH from Gradle, that would still work well for humans running the test script.
ghost
merged commit * GEODE-8382: Run Redis tests against Redis API for Geode * PR review changes * Sets JAVA_TEST_PATH variable as part of ssh call
4 participants
We would like to run Redis's tests against Redis API for Geode. Tests will run a separate job in the PR and main pipelines. It has been included in the 'tests' jinja variables.
Co-authored-by: Murtuza Boxwala mboxwala@pivotal.io