Skip to content

GEODE-8462: Make geode server startup fail if geode redis server has a port conflict#5483

Merged
jdeppe-pivotal merged 2 commits into
apache:developfrom
jhutchison:GEODE-8462-fail-if-port-in-use
Sep 3, 2020
Merged

GEODE-8462: Make geode server startup fail if geode redis server has a port conflict#5483
jdeppe-pivotal merged 2 commits into
apache:developfrom
jhutchison:GEODE-8462-fail-if-port-in-use

Conversation

@jhutchison
Copy link
Copy Markdown
Contributor

@jhutchison jhutchison commented Aug 27, 2020

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@jhutchison jhutchison changed the title GEODE-8462: Make geode server startup fail if geode redis server has … GEODE-8462: Make geode server startup fail if geode redis server has port conflict Aug 27, 2020
@jhutchison jhutchison changed the title GEODE-8462: Make geode server startup fail if geode redis server has port conflict GEODE-8462: Make geode server startup fail if geode redis server has a port conflict Aug 27, 2020
@jdeppe-pivotal jdeppe-pivotal added the redis Issues related to the geode-for-redis module label Aug 28, 2020
@jhutchison jhutchison force-pushed the GEODE-8462-fail-if-port-in-use branch from 4563460 to 3699644 Compare August 28, 2020 15:28
@ringles ringles force-pushed the GEODE-8462-fail-if-port-in-use branch from a7eeda0 to 6bebff8 Compare September 2, 2020 20:45
@jdeppe-pivotal jdeppe-pivotal merged commit 1076193 into apache:develop Sep 3, 2020
@sabbey37 sabbey37 deleted the GEODE-8462-fail-if-port-in-use branch September 3, 2020 13:57
dschneider-pivotal added a commit to dschneider-pivotal/geode that referenced this pull request Sep 15, 2020
dschneider-pivotal added a commit to dschneider-pivotal/geode that referenced this pull request Sep 15, 2020
…edis server has a port conflict (apache#5483)""

This reverts commit d0e21e6.
dschneider-pivotal added a commit to dschneider-pivotal/geode that referenced this pull request Sep 15, 2020
… geode redis server has a port conflict (apache#5483)"""

This reverts commit f8809da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

redis Issues related to the geode-for-redis module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants