GEODE-6622: WAN rolling upgrade test bind exception #5854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demery-pivotal
requested review from
dschneider-pivotal,
gesterzhou,
jchen21,
jinmeiliao,
kirklund and
mhansonp
mhansonp
approved these changes
Dec 15, 2020
Before: Several WAN rolling upgrade tests allocated ports for two locators by making two separate calls to AvailablePort. AvailablePort randomly samples ports with replacement, and so two calls can return the same port if the port is not put into use between the calls. From time to time, a test would get the same port for both locators, and the second would fail to start because its port was already in use. Now: The tests allocate both ports at the same time, ensuring that the two ports differ. And they get their ports from AvailablePortHelper, which allocates ports round robin instead of sampling with replacement, further reducing the chance of collisions.
demery-pivotal
force-pushed
the
geode-6622
branch
from
10ccaa6 to
ac196e8
Compare
mhansonp
approved these changes
Dec 16, 2020
Contributor
mhansonp
left a comment
mhansonp
left a comment
There was a problem hiding this comment.
Thanks for cleaning these up!
Contributor
Author
|
The one failing distributed test (MemberMXBeanDistributedTest) is unrelated to this PR and is known to fail intermittently: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: WANRollingUpgradeSecondaryEventsNotReprocessedAfterCurrentSiteMemberFailover allocated ports for two locators by making two separate calls to AvailablePort. AvailablePort randomly samples ports with replacement, and so two calls can return the same port if the port is not put into use between the calls.
Now: The test allocates both ports at the same time, and does so via AvailablePortHelper, which samples ports round robin rather than random with replacement.