Geode-8853: DUNIT tests for HSTRLEN command#5939
Merged
jdeppe-pivotal merged 8 commits intoapache:developfrom Jan 26, 2021
ringles:GEODE-8853-integration-tests-HSTRLEN
Merged
Geode-8853: DUNIT tests for HSTRLEN command#5939jdeppe-pivotal merged 8 commits intoapache:developfrom ringles:GEODE-8853-integration-tests-HSTRLEN
jdeppe-pivotal merged 8 commits intoapache:developfrom
ringles:GEODE-8853-integration-tests-HSTRLEN
Conversation
ringles
requested review from
davebarnes97,
jdeppe-pivotal,
karensmolermiller,
nonbinaryprogrammer,
pivotal-amurmann,
sabbey37 and
upthewaterspout
as code owners
sabbey37
approved these changes
Jan 21, 2021
Member
sabbey37
left a comment
sabbey37
left a comment
There was a problem hiding this comment.
It seems good! I always worry there are scenarios I'm forgetting about.
jhutchison
reviewed
Jan 21, 2021
jhutchison
reviewed
Jan 21, 2021
sabbey37
requested changes
Jan 21, 2021
Comment on lines
+202
to
+261
| @Test | ||
| public void testHStrlen_givenWrongNumberOfArguments() { | ||
| assertThatThrownBy(() -> jedis.sendCommand(Protocol.Command.HSTRLEN)) | ||
| .hasMessageContaining("wrong number of arguments"); | ||
| assertThatThrownBy(() -> jedis.sendCommand(Protocol.Command.HSTRLEN, "1")) | ||
| .hasMessageContaining("wrong number of arguments"); | ||
| assertThatThrownBy(() -> jedis.sendCommand(Protocol.Command.HSTRLEN, "1", "2", "3")) | ||
| .hasMessageContaining("wrong number of arguments"); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Thanks for adding these! I made this comment in the HSETNX PR as well:
I know for most of the other commands (del, getset, exists, etc.) we check the error message more closely, like:
.hasMessage("ERR wrong number of arguments for 'get' command");
I'm not sure if it's necessary, but maybe we could do the same here to be consistent? I realize there are a few areas where we're still just checking wrong number of arguments. We could eventually change those in a different PR.
Member
There was a problem hiding this comment.
Did we want to change this? Or create a different PR for it? Or not change it? Or something else?
Contributor
There was a problem hiding this comment.
I second this. It would be pretty awkward to return an error message for the wrong command
sabbey37
approved these changes
Jan 22, 2021
nonbinaryprogrammer
approved these changes
Jan 25, 2021
- test the error messages for hgetall and hstrlen more specifically - fix an hgetall test that was testing the wrong command
demery-pivotal
pushed a commit
to demery-pivotal/geode
that referenced
this pull request
Jan 29, 2021
- test the error messages for hgetall and hstrlen more specifically - fix an hgetall test that was testing the wrong command Co-authored-by: Ray Ingles <ringles@vmware.com> Co-authored-by: Helena A. Bales <hbales@pivotal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DUNIT test for HSTRLEN Redis command, promote to "supported".