GEODE-8875: Removing packages element from log4j2 configuration file #5957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This element causes log4j to scan all geode jars on startup. This slows down the startup time of all geode processes, including gfsh. It is not necessary because log4j has an annotation processor to generate a config file that helps it find plugs that it needs.
upthewaterspout
requested review from
davebarnes97,
jdeppe-pivotal,
jinmeiliao,
karensmolermiller,
kirklund,
mhansonp and
onichols-pivotal
as code owners
jdeppe-pivotal
approved these changes
Jan 27, 2021
Contributor
jdeppe-pivotal
left a comment
jdeppe-pivotal
left a comment
There was a problem hiding this comment.
Awesome! I see a 6x speedup in test starts now.
karensmolermiller
approved these changes
Jan 27, 2021
Contributor
karensmolermiller
left a comment
karensmolermiller
left a comment
There was a problem hiding this comment.
The docs change looks good to me. I haven't looked at the code/test changes.
Fixing a suspect string from RestartOfMemberDistributedTest. This test is crashing the distributed system, so it is expected to see AlertAppender errors. We suspect the log4j changes affected the timing of the test. The fact that we are seeing AlertAppender errors indicates that log4j is definitely finding our log4j plugins! Removing a packages element from the log4j2.xml file checked into the membership module.
bschuchardt
approved these changes
Jan 29, 2021
Contributor
bschuchardt
left a comment
bschuchardt
left a comment
There was a problem hiding this comment.
If the premise is correct I don't have a problem with the changes to the membership test or log4j configuration.
ghost
approved these changes
Jan 30, 2021
kirklund
approved these changes
Feb 1, 2021
mhansonp
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This element causes log4j to scan all geode jars on startup. This slows down
the startup time of all geode processes, including gfsh.
It is not necessary because log4j has an annotation processor to generate a
config file that helps it find plugs that it needs.