GEODE-9047: Cleanup package management.internal.cli.result #6185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirklund
changed the title
kirklund
requested review from
boglesby,
jdeppe-pivotal,
jinmeiliao,
mhansonp and
nabarunnag
as code owners
jinmeiliao
approved these changes
Mar 25, 2021
DonalEvans
requested changes
Mar 25, 2021
Contributor
DonalEvans
left a comment
DonalEvans
left a comment
There was a problem hiding this comment.
Just a few small suggestions.
...t/java/org/apache/geode/management/internal/cli/result/model/ResultModelIntegrationTest.java
Outdated
Show resolved
Hide resolved
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/result/ColumnTest.java
Outdated
Show resolved
Hide resolved
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/result/TableBuilderTest.java
Show resolved
Hide resolved
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/result/TableBuilderTest.java
Outdated
Show resolved
Hide resolved
geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/result/TableBuilderTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@DonalEvans Think of this PR has a first pass cleaning up this package and its tests. I didn't actually write new tests. We can keep cleaning up more in followup PRs. |
DonalEvans
approved these changes
Mar 25, 2021
boglesby
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Donal removed PowerMock from a test in this package, I made a first pass over cleaning it up further.
None of these classes ever go on the wire: