GEODE-9064: Configure serial filter during ManagementAgent start#6196
Merged
kirklund merged 3 commits intoapache:developfrom Apr 6, 2021
Merged
GEODE-9064: Configure serial filter during ManagementAgent start#6196kirklund merged 3 commits intoapache:developfrom
kirklund merged 3 commits intoapache:developfrom
Conversation
kirklund
force-pushed
the
GEODE-9064-jmxrmi-filtering-01
branch
3 times, most recently
from
6cf68cd to
e57a5dc
Compare
kirklund
changed the title
kirklund
force-pushed
the
GEODE-9064-jmxrmi-filtering-01
branch
from
064a8ac to
7d1a6d8
Compare
kirklund
requested review from
jdeppe-pivotal,
jinmeiliao and
onichols-pivotal
as code owners
onichols-pivotal
approved these changes
Mar 31, 2021
ghost
approved these changes
Mar 31, 2021
jinmeiliao
requested changes
Apr 1, 2021
| import org.apache.geode.test.assertj.LogFileAssert; | ||
| import org.apache.geode.test.junit.rules.RequiresGeodeHome; | ||
|
|
||
| public class LocatorManagerConfiguresSerialFilterAcceptanceTest { |
Member
There was a problem hiding this comment.
Suggestion: using GfshRule to launch a locator/server would greatly reduce the boiler plate code
| import org.apache.geode.test.assertj.LogFileAssert; | ||
| import org.apache.geode.test.junit.rules.RequiresGeodeHome; | ||
|
|
||
| public class ServerManagerConfiguresSerialFilterAcceptanceTest { |
Member
There was a problem hiding this comment.
Suggestion: using GfshRule to launch a locator/server would greatly reduce the boiler plate code
| * greater than Java 8. If the system property already has a non-null value with a length greater | ||
| * than zero, then leave it as is. | ||
| */ | ||
| void configureSerialFilterIfEmpty(); |
Member
There was a problem hiding this comment.
This "if empty" is implementation specific. As an interface user, we just want to call configureSerialFilter(), as to whether/how you configure it, it depends on the implementer.
Contributor
Author
There was a problem hiding this comment.
I renamed this configureSerialFilter. I also renamed some classes and test classes to hopefully have better names.
| public interface JmxRmiSerialFilter { | ||
|
|
||
| /** | ||
| * Configure the “jmx.remote.rmi.server.serial.filter.pattern” system property if Java version is |
Member
There was a problem hiding this comment.
this comment probably only applies to the implementor of the interface
Contributor
Author
There was a problem hiding this comment.
I removed javadocs from JmxRmiSerialFilter. If I think of some better javadocs, I'll add them in.
The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone.
kirklund
force-pushed
the
GEODE-9064-jmxrmi-filtering-01
branch
from
b094b89 to
acb1976
Compare
Rename classes and tests
jinmeiliao
approved these changes
Apr 5, 2021
kirklund
added a commit
that referenced
this pull request
Apr 6, 2021
The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit c43dbc5)
kirklund
added a commit
that referenced
this pull request
Apr 6, 2021
The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit c43dbc5)
kirklund
added a commit
that referenced
this pull request
Apr 6, 2021
The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit c43dbc5)
kirklund
added a commit
that referenced
this pull request
Apr 6, 2021
The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit c43dbc5)
nabarunnag
added a commit
to nabarunnag/geode
that referenced
this pull request
Apr 7, 2021
…art (apache#6196)" This reverts commit 74e5564.
6 tasks
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 15, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit c43dbc5)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 15, 2021
…art (apache#6196)" Reverting due to possible related timeouts in geode-core distributed test jobs. This reverts commit c43dbc5.
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 15, 2021
…art (apache#6196)" Reverting due to possible related timeouts in geode-core distributed 4 test jobs. This reverts commit 74e5564.
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 15, 2021
…art (apache#6196)" Reverting due to possible related timeouts in geode-core distributed 4 test jobs. This reverts commit 5a3de78.
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone.
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
that referenced
this pull request
Apr 16, 2021
The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 16, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit b280355)
kirklund
added a commit
that referenced
this pull request
Apr 22, 2021
…) (#6336) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone.
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 22, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 22, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 22, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
kirklund
added a commit
to kirklund/geode
that referenced
this pull request
Apr 22, 2021
…che#6196) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
kirklund
added a commit
that referenced
this pull request
Apr 26, 2021
…) (#6337) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
kirklund
added a commit
that referenced
this pull request
Apr 26, 2021
…) (#6338) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
kirklund
added a commit
that referenced
this pull request
Apr 26, 2021
…) (#6341) The Geode JMX layer will configure the system property “jmx.remote.rmi.server.serial.filter.pattern" to only accept JDK classes identified as open-types required for JMX. If the system property already has a value then Geode will log a statement and leave the system property alone. (cherry picked from commit 8b2ee6d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Geode JMX layer will configure the system property
“jmx.remote.rmi.server.serial.filter.pattern" to only accept
JDK classes identified as open-types required for JMX.
If the system property already has a value then Geode will log
a statement and leave the system property alone.
If the Java version is Java 8 then the system property does
not exist and will not be set.
Further pull requests may be submitted for Java 8.