a first whack at ByteBufferSharing to fix TLS handshake corruption #6219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschuchardt
reviewed
Mar 30, 2021
Contributor
bschuchardt
left a comment
bschuchardt
left a comment
There was a problem hiding this comment.
I think this is a good solution
| getBufferPool()); | ||
| } | ||
|
|
||
| private ByteBufferSharing shareInputBuffer() throws IOException { |
Contributor
There was a problem hiding this comment.
since you're using inputSharing.close() everywhere you could similarly use inputSharing.close() instead of putting it in this method. That might be easier to follow.
Contributor
Author
There was a problem hiding this comment.
yes to inlining this method!
bschuchardt
reviewed
Mar 30, 2021
| inputBuffer = null; | ||
| getBufferPool().releaseReceiveBuffer(tmp); | ||
| } | ||
| inputSharing.close(); |
Contributor
There was a problem hiding this comment.
I'm wondering if this method needs to claim its own reference to the buffer to balance this close()
Contributor
Author
|
An alternative PR, using this same approach, has been merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.