GEODE-8899: Prep CI scripts for upcoming DUnit command line changes #6254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change CI scripts to support running parallel DUnit tests with either Geode's current Gradle 5.5 build or the upcoming Gradle 6.8.3 build. This allows testing the upgrade to Gradle 6.8.3 in the PR precheckin pipeline. Where the current build uses a single command line option (-PdunitParallelForks) to specify the maximum number of parallel dockerized test workers, the upcoming build uses two (--max-workers and -PtestMaxParallelForks). This commit changes the CI build scripts to specify all three options on the Gradle command line for parallel DUnit tests. With this commit: - If the scripts run a Gradle 5.5 build, the old option will configure the tests, and the new options will have no effect. - If the scripts run a Gradle 6.8.3 build, the new options will configure the tests, and the old option will have no effect. Authored-by: Dale Emery <demery@vmware.com>
demery-pivotal
requested review from
dickcav and
onichols-pivotal
as code owners
onichols-pivotal
approved these changes
Apr 2, 2021
dickcav
approved these changes
Apr 2, 2021
ghost
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CI scripts to support running parallel DUnit tests with either
Geode's current Gradle 5.5 build or the upcoming Gradle 6.8.3 build.
This allows testing the upgrade to Gradle 6.8.3 in the PR precheckin
pipeline.
Where the current build uses a single command line option
(-PdunitParallelForks) to specify the maximum number of parallel
dockerized test workers, the upcoming build uses two (--max-workers and
-PtestMaxParallelForks).
This commit changes the CI build scripts to specify all three options on
the Gradle command line for parallel DUnit tests. With this commit:
If the scripts run a Gradle 5.5 build, the old option will configure
the tests, and the new options will have no effect.
If the scripts run a Gradle 6.8.3 build, the new options will
configure the tests, and the old option will have no effect.
Authored-by: Dale Emery demery@vmware.com
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.