Skip to content

DRAFT: GEODE-9132 changes --> feature/GEODE-7665 #2 #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kirklund merged 15 commits into from
Apr 22, 2021
Merged

DRAFT: GEODE-9132 changes --> feature/GEODE-7665 #2 #6334

kirklund merged 15 commits into from
Apr 22, 2021

Conversation

@kirklund
Copy link
Contributor

@kirklund kirklund commented Apr 16, 2021

In-progress changes for Partitioned Region Clear feature branch.

kirklund added 8 commits April 15, 2021 15:59
@kirklund
GEODE-9132: Delete ClearPRMessage
902984f
@kirklund
GEODE-9132: Fixup PartitionResponse constructors
274e191 
* Chain constructors to only one constructor that calls super
* Expose all arguments for dependency injection
* Provide type to recipients
@kirklund
GEODE-9132: Cleanup PartitionedRegionClearMessage
fb90ad4 
* Use descriptive names for variables and methods
* Use Objects.requireNonNull instead of Assert.assertTrue
* Remove unnecessary uses of final, this, and super
* Use static logger
* Reformat some lines with weird formatting
@kirklund
GEODE-9132: Remove unused DSFID constants
62edccb
@kirklund
GEODE-9132: Undelete unnecessary uses of final
ccc5e67
@kirklund
GEODE-9132: Cleanup PartitionedRegionPartialClearException
5f55886 
* Generate serialVersionUID
* Use full words for parameter names
@kirklund
GEODE-9132: Remove ClearPRMessage from sanctionedDataSerializables.txt
549e9ad
@kirklund
Fixup AnalyzeCoreSerializablesJUnitTest for PartitionedRegionPartialC…
0e7bca0 
…learException
@kirklund
Copy link
Contributor Author

kirklund commented Apr 16, 2021

DistributedTestOpen failed with:

> Task :geode-wan:distributedTest

org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest > testPRParallelPropagationWithGroupTransactionEventsDoesNotSendBatchesWithIncompleteTransactionsIfGatewaySenderIsStoppedWhileReceivingTrafficAndLaterStarted FAILED
    java.lang.AssertionError: expected:<0> but was:<1>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest.checkOnlyCompleteTransactionsAreReplicatedAfterSenderStopped(ParallelWANStatsDUnitTest.java:612)
        at org.apache.geode.internal.cache.wan.parallel.ParallelWANStatsDUnitTest.testPRParallelPropagationWithGroupTransactionEventsDoesNotSendBatchesWithIncompleteTransactionsIfGatewaySenderIsStoppedWhileReceivingTrafficAndLaterStarted(ParallelWANStatsDUnitTest.java:520)

And:

> Task :geode-core:distributedTest

org.apache.geode.management.MemberMXBeanDistributedTest > testBucketCount FAILED
    org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in org.apache.geode.management.MemberMXBeanDistributedTest expected:<[400]0> but was:<[375]0> within 5 minutes.
        at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
        at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
        at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
        at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
        at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
        at org.apache.geode.management.MemberMXBeanDistributedTest.testBucketCount(MemberMXBeanDistributedTest.java:108)

        Caused by:
        java.util.concurrent.TimeoutException
            at java.util.concurrent.FutureTask.get(FutureTask.java:204)
            at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:101)
            at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:81)
            at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:101)
            ... 5 more

@kirklund kirklund force-pushed the GEODE-9132-PR-clear-locking-cleanup-03 branch from fe94c92 to 33b3293 Compare April 20, 2021 17:08
@kirklund
Copy link
Contributor Author

kirklund commented Apr 20, 2021

UnitTestOpenJDK8 and UnitTestOpenJDK11 both failed in an unrelated unit test:

> Task :geode-core:test

org.apache.geode.internal.classloader.ClassPathLoaderTest > testZeroLengthFile FAILED
    java.lang.AssertionError: 
    Expecting actual throwable to be an instance of:
      java.lang.IllegalArgumentException
    but was:
      java.lang.NullPointerException
    	at java.base/java.io.File.<init>(File.java:364)
    	at org.apache.geode.deployment.internal.JarDeployer.getNextVersionedJarFile(JarDeployer.java:101)
    	at org.apache.geode.deployment.internal.JarDeployer.deployWithoutRegistering(JarDeployer.java:84)
    	...(59 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
        at org.apache.geode.internal.classloader.ClassPathLoaderTest.testZeroLengthFile(ClassPathLoaderTest.java:109)

@kirklund
Copy link
Contributor Author

kirklund commented Apr 21, 2021

IntegrationTestOpen timeout exceeded.

Both UnitTestOpen jobs fail with unrelated failure:

org.apache.geode.internal.classloader.ClassPathLoaderTest > testZeroLengthFile FAILED
    java.lang.AssertionError: 
    Expecting actual throwable to be an instance of:
      java.lang.IllegalArgumentException
    but was:
      java.lang.NullPointerException
    	at java.base/java.io.File.<init>(File.java:364)
    	at org.apache.geode.deployment.internal.JarDeployer.getNextVersionedJarFile(JarDeployer.java:101)
    	at org.apache.geode.deployment.internal.JarDeployer.deployWithoutRegistering(JarDeployer.java:84)
    	...(59 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
        at org.apache.geode.internal.classloader.ClassPathLoaderTest.testZeroLengthFile(ClassPathLoaderTest.java:109)

@kirklund kirklund mentioned this pull request Apr 21, 2021
Closed
@kirklund kirklund merged commit a8d9e52 into apache:feature/GEODE-7665 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdeppe-pivotal jdeppe-pivotal Awaiting requested review from jdeppe-pivotal jdeppe-pivotal will be requested when the pull request is marked ready for review jdeppe-pivotal is a code owner

@nabarunnag nabarunnag Awaiting requested review from nabarunnag nabarunnag will be requested when the pull request is marked ready for review nabarunnag is a code owner

@DonalEvans DonalEvans Awaiting requested review from DonalEvans DonalEvans will be requested when the pull request is marked ready for review DonalEvans is a code owner

@agingade agingade Awaiting requested review from agingade agingade will be requested when the pull request is marked ready for review agingade is a code owner

@boglesby boglesby Awaiting requested review from boglesby boglesby will be requested when the pull request is marked ready for review boglesby is a code owner

@BenjaminPerryRoss BenjaminPerryRoss Awaiting requested review from BenjaminPerryRoss BenjaminPerryRoss will be requested when the pull request is marked ready for review BenjaminPerryRoss is a code owner

@jchen21 jchen21 Awaiting requested review from jchen21 jchen21 will be requested when the pull request is marked ready for review jchen21 is a code owner

@dschneider-pivotal dschneider-pivotal Awaiting requested review from dschneider-pivotal dschneider-pivotal will be requested when the pull request is marked ready for review dschneider-pivotal is a code owner

@echobravopapa echobravopapa Awaiting requested review from echobravopapa echobravopapa will be requested when the pull request is marked ready for review echobravopapa is a code owner

@Bill Bill Awaiting requested review from Bill Bill will be requested when the pull request is marked ready for review Bill is a code owner

@kamilla1201 kamilla1201 Awaiting requested review from kamilla1201 kamilla1201 will be requested when the pull request is marked ready for review kamilla1201 is a code owner

@upthewaterspout upthewaterspout Awaiting requested review from upthewaterspout upthewaterspout will be requested when the pull request is marked ready for review upthewaterspout is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kirklund