GEODE-8899: Temporarily restore dunitParallelForks #6335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my earlier commit to upgrade Gradle to v6.8.3, I inadvertently removed the `-PdunitParallelForks` option from the build and test CI scripts. Some PRs do not yet include the Gradle upgrade. Without this option, the Dockerized tests for those those PRs use only 8 test workers. Those test tasks will likely time out. The CI scripts must continue to specify `-PdunitParallelForks=<N>` until all PRs include the Gradle upgrade. Authored-by: Dale Emery <demery@vmware.com>
demery-pivotal
requested review from
dickcav and
onichols-pivotal
as code owners
onichols-pivotal
approved these changes
Apr 16, 2021
Contributor
onichols-pivotal
left a comment
onichols-pivotal
left a comment
There was a problem hiding this comment.
I hope this is more permanent than temporary. The develop PR pipeline serves all support branches, which means for at least two more years it will need to be able to run old gradle as well as new.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my earlier commit to upgrade Gradle to v6.8.3, I inadvertently
removed the
-PdunitParallelForksoption from the build and test CIscripts.
Some PRs do not yet include the Gradle upgrade. Without this option, the
Dockerized tests for those those PRs use only 8 test workers. Those
test tasks will likely time out.
The CI scripts must continue to specify
-PdunitParallelForks=<N>untilall PRs include the Gradle upgrade.
Authored-by: Dale Emery demery@vmware.com
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.