Skip to content

Conversation

@boglesby
Copy link
Contributor

…layed

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@boglesby boglesby added the windows add this label to get Windows JDK11 PR checks too label Apr 27, 2021
@boglesby boglesby added windows add this label to get Windows JDK11 PR checks too and removed windows add this label to get Windows JDK11 PR checks too labels Apr 29, 2021
@boglesby boglesby marked this pull request as ready for review April 30, 2021 16:16
Copy link
Contributor

@jdeppe-pivotal jdeppe-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boglesby boglesby merged commit 91edb37 into develop Apr 30, 2021
@boglesby boglesby deleted the feature/GEODE-9104 branch April 30, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows add this label to get Windows JDK11 PR checks too

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants